Skip to content

chore(protocols): ospf.py defines an unused PAT_MAC_ADDR #1844

Closed
#1864
Closed
chore(protocols): ospf.py defines an unused PAT_MAC_ADDR#1844
#1864
Labels
choreMaintenance work: tooling, repo hygiene, no library behaviour change

Description

@JarryShaw
JarryShaw
opened on Oct 16, 2026

pcapkit/protocols/application/ospf.py:87-88 defines PAT_MAC_ADDR, and import re (:58) exists only for it. Nothing reads it: git grep PAT_MAC_ADDR across pcapkit, tests, docs, examples and util finds only this definition, plus the separate copies in link/ethernet.py, link/arp.py and misc/pcapng.py, which do have readers. It is not in __all__, and it came over unchanged when OSPF moved to this path in 1.5.0 (#1031).

Fix: delete the constant and the import.

Activity

  1. JarryShaw
    added
    choreMaintenance work: tooling, repo hygiene, no library behaviour change
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 16, 2026
  2. JarryShaw
    added this to PyPCAPKiton Oct 16, 2026
  3. JarryShaw
    moved this to WIP in PyPCAPKiton Oct 16, 2026
  4. JarryShaw
    closed this as completedin #1864on Oct 16, 2026
  5. github-project-automation
    moved this from WIP to Done in PyPCAPKiton Oct 16, 2026
  6. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance work: tooling, repo hygiene, no library behaviour change

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions