Skip to content

fix(ci): Vendor Update bumps for a new const module but never commits it #1685

Closed

Description

@JarryShaw

Describe the bug
Vendor Update commits with git commit -am (.github/workflows/cron-vendor.yml:267). That stages modified and deleted tracked files, but never untracked ones. So when a crawl generates a brand-new const module, for a registry IANA added:

  • tj-actions/verify-changed-files reports it, so files_changed is true;
  • Bump Version runs, and the version is bumped and pushed;
  • but the new module itself is left out of the commit.
    The release then ships without the module that justified it, and every later crawl finds it untracked again, so it bumps every run.

Found while reviewing #1684, which keeps this step as is; its comment-only path never sees a new file, because a new file always classifies as code.

Expected behavior
Vendor Update commits every file verify-changed-files reports, untracked ones included (for example git add -A pcapkit/const before the commit), so a bump always carries the files that caused it.

Activity

  1. JarryShaw commented on Oct 13, 2026

    @JarryShaw
    OwnerAuthor

    Blocked until #1684 merges, because it rewrites the same commit steps in cron-vendor.yml.

  2. added
    fixPull requests that fix a defect (fix: subject prefix)
    ciPull requests that change CI or workflow configuration (ci: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 13, 2026
  3. moved this to Blocked in PyPCAPKiton Oct 13, 2026
  4. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 13, 2026
  5. JarryShaw commented on Oct 13, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1684 has merged. A worker has this.

  6. moved this from Blocked to WIP in PyPCAPKiton Oct 13, 2026
  7. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciPull requests that change CI or workflow configuration (ci: subject prefix)fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions