Skip to content

fix(reassembly): a datagram whose header plus data exceeds 65,535 octets still reads COMPLETE #1585

Closed

Description

@JarryShaw

These are follow-ups from the #1582 cross-review, both in pcapkit/foundation/reassembly/ip.py.

  1. A datagram longer than the protocol allows still completes.
  2. The _detect_conflicts docstring is stale since fix(reassembly): only the final fragment's partial block counts, and an oversized datagram never completes (#1566, #1567) #1582.

Blocked until #1582 merges, because it changes the same file.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 10, 2026
  2. JarryShaw commented on Oct 10, 2026

    @JarryShaw
    OwnerAuthor

    Work has started ahead of #1582 merging, on a branch built on #1582's head e8273d9d6. Its PR opens, rebased onto main, once #1582 merges.

  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 10, 2026
  4. moved this from Blocked to WIP in PyPCAPKiton Oct 10, 2026
  5. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 10, 2026
  6. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions