Skip to content

test(foundation): engine agreement module flakes on tshark crashes (TSharkCrashException, retcode 255) #1534

Closed

Description

@JarryShaw

tests/foundation/engines/test_engine_agreement_runtime.py (added in #1508) fails intermittently. tshark exits with retcode 255, and pyshark raises TSharkCrashException: TShark (pid N) seems to have crashed (retcode: 255).

The harness caches one run per capture, so a single crash fails every pyshark aspect of that capture: 9 ERROR != OK subtests.

Seen so far, always on a different capture, and never reproducing on a rerun:

Fix: retry a pyshark run once on TSharkCrashException before recording ERROR, and log the retry so a persistent crash still fails. Do not turn it into a skip.

Activity

  1. added
    testPull requests that add or correct tests (test: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 9, 2026
  2. JarryShaw commented on Oct 9, 2026

    @JarryShaw
    OwnerAuthor

    More detail on the cause, from the #1527 worker. When this happens, asyncio logs Unknown child process pid N, will report returncode 255. Something else in the process collected tshark's exit status before pyshark could, and pyshark reports that as a crash. The worker reproduced it on plain main in 3 of 6 all-engine scripted runs; 184 standalone pyshark reads never crashed. The retry in #1536 handles the symptom, but the competing child-reaping is the likely root cause.

  3. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testPull requests that add or correct tests (test: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions