Repository navigation
fix(toolkit): pyshark TCP trace crashes because tshark 4.x reports flags as 'True'/'False' #1514
Description
pcapkit/toolkit/pyshark.py:415-417 parses bool(int(tcp.flags_syn)), and likewise for flags_fin and flags_reset. tshark 4.x reports these fields as 'True'/'False'. I measured repr(p.tcp.flags_syn) == "'True'" with tshark 4.6.9, and CI runs 4.2.2. The first traced TCP frame therefore raises ValueError: invalid literal for int() with base 10: 'True'.
Per the #1508 worker, this fails every aspect on all 9 captures that have TCP flows.
Expected: accept both the '1'/'0' and the 'True'/'False' forms.
Activity
JarryShaw commentedon Oct 9, 2026
Blocked until #1508 merges. That PR adds this defect's known-failure row in
tests/foundation/engines/test_engine_agreement_runtime.py, and a fix has to delete that row, so the fix waits for the row to exist onmain.JarryShaw commentedon Oct 9, 2026
Unblocked: #1508 has merged, so this defect's known-failure row is on
main. A worker is on the fix, and the fix PR deletes the row.fix(toolkit): accept tshark's True/False TCP flags in the pyshark tra…
fix(toolkit): accept tshark's True/False TCP flags in the pyshark tra…