Repository navigation
fix(corekit): ListField, PayloadField and SchemaField have no default name #1491
Description
Describe the bug
A ListField that has not been given a name has no name at all, yet OptionField.unpack reads self.name.
Reproduction
from pcapkit.corekit.fields.collections import ListField
ListField().name # AttributeError: 'ListField' object has no attribute '_name'Expected behavior
A default name, as the other fields have, or an in-library error that says the field is unnamed.
System information
Linux, CPython 3.14.7, main at 00d232890.
Additional context
ListField.__init__ (pcapkit/corekit/fields/collections.py:95-106) sets no _name.
Found by the #1202 corekit round-trip slice.
Activity
JarryShaw commentedon Oct 9, 2026
Widening scope. The #1493 worker found the same gap in two more fields, and I measured it on
00d232890:Field().namePayloadField(pcapkit/corekit/fields/misc.py:223)AttributeError: ... no attribute '_name'SchemaField(misc.py:621)AttributeError: ... no attribute '_name'SwitchField,ForwardMatchFieldEach of the four has its default name commented out (
misc.py:310,:459,:655,:828). #1493 will add the default toPayloadFieldandSchemaFieldtoo, using the sameFieldBaseidiom (field.py:348-349).[-]fix(corekit): ListField().name raises AttributeError[/-][+]fix(corekit): ListField, PayloadField and SchemaField have no default name[/+]fix(corekit): give unnamed ListField, PayloadField and SchemaField a …
fix(corekit): give unnamed ListField, PayloadField and SchemaField a …