Repository navigation
fix(corekit): a ListField without item_type cannot pack what it unpacks #1489
Description
Describe the bug
unpack returns bytes, and pack then rejects those bytes.
Reproduction
from pcapkit.corekit.fields.collections import ListField
f = ListField(length=4); f.name = 'items'; f = f({})
f.pack(f.unpack(b'abcd', {}), {}) # FieldValueError: Field items has invalid value.Expected behavior
b'abcd'.
System information
Linux, CPython 3.14.7, main at 00d232890.
Additional context
unpack returns file.read(length) (pcapkit/corekit/fields/collections.py:179), and pack iterates that as items, so it rejects each int (:146, :154). Schema.pack writes bytes values itself (pcapkit/protocols/schema/schema.py:846), so only direct use of the field is affected.
Found by the #1202 corekit round-trip slice.
Activity
test(corekit): field, schema and Info round trips (#1202)
JarryShaw commentedon Oct 9, 2026
Blocked until #1492 merges. #1492 adds the
Gaprow for this defect totests/corekit/_roundtrip.py, and the fix must delete that row in the same PR.test(corekit): field, schema and Info round trips (#1202) (#1492)
JarryShaw commentedon Oct 9, 2026
Unblocked: #1492 merged (
d9e12e82e). A worker is starting on this against currentmain; the fix PR deletes this defect'sGaprow.fix(corekit): an untyped ListField packs the bytes it unpacks (#1489) (…