Repository navigation
fix(corekit): a NumberField whose bit_length is narrower than its octets drops the high bits #1488
Description
Describe the bug
An integer field with bit_length smaller than its width does not round-trip.
Reproduction
from pcapkit.corekit.fields.numbers import UInt16Field
f = UInt16Field(bit_length=12)({})
f.pack(f.unpack(b'\xff\xff', {}), {}).hex() # '0fff'Expected behavior
'ffff'. EnumField(length=1, bit_length=3) behaves the same way.
System information
Linux, CPython 3.14.7, main at 00d232890.
Additional context
Both pack and unpack mask with _bit_mask (pcapkit/corekit/fields/numbers.py:318, :322). The only shipped use is vlan.TCI (pcapkit/protocols/schema/link/vlan.py:47-51), which no protocol parses with.
Found by the #1202 corekit round-trip slice.
Activity
test(corekit): field, schema and Info round trips (#1202)
JarryShaw commentedon Oct 9, 2026
Blocked until #1492 merges. #1492 adds the
Gaprow for this defect totests/corekit/_roundtrip.py, and the fix must delete that row in the same PR.test(corekit): field, schema and Info round trips (#1202) (#1492)
JarryShaw commentedon Oct 9, 2026
Unblocked: #1492 merged (
d9e12e82e). A worker is starting on this against currentmain; the fix PR deletes this defect'sGaprow.fix(corekit): keep a NumberField's bits outside bit_length as captured (
fix(corekit): keep a NumberField's bits outside bit_length as captured (
fix(corekit): keep a NumberField's bits outside bit_length as captured (
fix(corekit): keep a NumberField's bits outside bit_length as captured (
fix(corekit): keep a NumberField's bits outside bit_length as captured (
fix(corekit): keep a NumberField's bits outside bit_length as captured (