Repository navigation
fix(corekit): BitField drops the bits its namespace does not name #1487
Description
Describe the bug
An unpacked BitField re-packs to different bytes when its namespace leaves bits unnamed.
Reproduction
from pcapkit.corekit.fields.strings import BitField
f = BitField(length=2, namespace={'a': (0, 1), 'c': (8, 4)})({})
f.pack(f.unpack(b'\xff\xff', {}), {}).hex() # '80f0'Expected behavior
'ffff': the unnamed bits come back as captured.
System information
Linux, CPython 3.14.7, main at 00d232890.
Additional context
pack starts from all zeros (pcapkit/corekit/fields/strings.py:311), and unpack keeps only the named subfields (:334). None of the 102 BitFields in the shipped schemas leaves a bit unnamed, so no protocol is affected today; the #1202 corekit slice pins that.
Found by the #1202 corekit round-trip slice.
Activity
test(corekit): field, schema and Info round trips (#1202)
JarryShaw commentedon Oct 9, 2026
Blocked until #1492 merges. #1492 adds the
Gaprow for this defect totests/corekit/_roundtrip.py, and the fix must delete that row in the same PR.test(corekit): field, schema and Info round trips (#1202) (#1492)
JarryShaw commentedon Oct 9, 2026
Unblocked: #1492 merged (
d9e12e82e). A worker is starting on this against currentmain; the fix PR deletes this defect'sGaprow.fix(corekit): keep a BitField's unnamed bits as captured (#1487)
fix(corekit): keep a BitField's unnamed bits as captured (#1487) (#1495)