Skip to content

fix(sctp): a last chunk sent without its padding rebuilds with the padding zero-filled #1474

Closed

Description

@JarryShaw

Bug. When the last SCTP chunk arrives without its padding, the rebuild adds the missing padding octets as zeros.

Repro: the #1454 edge case sctp/last-chunk-unpadded, a DATA chunk of 1 octet with no padding, rebuilds 3 octets longer than captured. Four cut variants in tests/protocols/transport/test_transport_edge_roundtrip_unit.py fail the same way: data-1-octet-3-pad/cut31, data-nonzero-pad/cut31, unassigned-type-action-00/cut19 and unassigned-type-action-10/cut23.

This is not the #1458/#1465 short read, which only covers fields the capture ends inside. It is also not the #1468/#1472 trailer, which covers extra octets. Here the padding is simply absent, and padding_length, which chunks, parameters and causes share, always writes it.

Found by the #1465 and #1468 workers.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 9, 2026
  2. JarryShaw commented on Oct 9, 2026

    @JarryShaw
    OwnerAuthor

    Blocked until #1472 merges. #1472 rewrites SCTP's chunk-list parsing in pcapkit/protocols/schema/transport/sctp.py, which is where this fix goes.

  3. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 9, 2026
  4. JarryShaw commented on Oct 9, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1472 merged (6323852a7). A worker is starting on it against current main.

  5. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 9, 2026
  6. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions