fix(ospf): from_data(info.to_dict()) raises for cryptographic authentication

Bug. An OSPF packet with cryptographic authentication (AuType 2) does not rebuild from its dict form. from_data(info.to_dict()) raises instead of rebuilding.

Repro on main, and on #1460's head 325c6715b:

hdr = struct.pack('!BBHIIHH', 2, 1, 24, 0x01010101, 0, 0, 2) + struct.pack('!HBBI', 0, 1, 16, 7)
raw = hdr + b'\xaa'*16
o = OSPF(raw, len(raw))
OSPF.from_data(o.info).data == raw          # True
OSPF.from_data(o.info.to_dict())            # ProtocolError: OSPF: invalid type for auth_data: {...}

to_dict() flattens auth_data (a CryptographicAuthentication info) into a plain dict, and _make_data only accepts the info object. This is the same family as #1447: #1452 fixed payload dispatch, not nested data models.

Found by the #1460 cross-review.

Blocked until #1460 merges. #1460 changes ospf.py and its schema and data files, which is where this fix also goes. A worker starts from main once #1460 is in.

Unblocked: #1460 merged as f0230afde. Back to pending; a worker starts from main.

A worker is on it now, on branch fix/1464-ospf-auth-dict. It will also sweep the other protocols for the same nested-model shape.

fix(ospf): rebuild cryptographic authentication from its dict form (#…

Navigation Menu

Repository navigation

fix(ospf): from_data(info.to_dict()) raises for cryptographic authentication #1464

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

fix(ospf): from_data(info.to_dict()) raises for cryptographic authentication #1464

Description

Activity

JarryShaw commented on Oct 9, 2026

JarryShaw commented on Oct 9, 2026

JarryShaw commented on Oct 9, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions