Skip to content

fix(protocol): main is red, IPv4 make() with an unparsable raw item no longer raises the wrapped error #1394

Closed

Description

@JarryShaw

Describe the bug
main is red at 66950b1f2. The cause is a semantic conflict between #1344 (8ed5bd6ed, IPv4 option-area rebuild) and #1352 (66950b1f2, raw items in a make() list). Each passed CI on its own base.

tests/protocols/test_protocol_make_unit.py::TestMakeRawItems::test_unparsable_raw_item_raises_protocol_error expects make() to wrap the parse failure as ProtocolError: IPv4: malformed raw item given to make() (pcapkit/protocols/protocol.py:740, with the original error as __cause__). It now gets a bare IPv4: invalid format.

To Reproduce

Expected behavior
main is green: the test passes, or the test is changed for a stated reason. The fix must say which of the two is right.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
  2. added a commit that references this issue on Oct 8, 2026
    970fed9
  3. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
  4. added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions