You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(protocol): main is red, IPv4 make() with an unparsable raw item no longer raises the wrapped error #1394
Describe the bug main is red at 66950b1f2. The cause is a semantic conflict between #1344 (8ed5bd6ed, IPv4 option-area rebuild) and #1352 (66950b1f2, raw items in a make() list). Each passed CI on its own base.
tests/protocols/test_protocol_make_unit.py::TestMakeRawItems::test_unparsable_raw_item_raises_protocol_error expects make() to wrap the parse failure as ProtocolError: IPv4: malformed raw item given to make() (pcapkit/protocols/protocol.py:740, with the original error as __cause__). It now gets a bare IPv4: invalid format.
To Reproduce
IPv4(options=[b'\x02', b'\x94\x04\x00\x00'], protocol=253) on main.
Activity
fix(protocol): main is red, IPv4 make() with an unparsable raw item n…
fix(protocols)!: a declared length running past the data is accepted …
fix(protocols)!: a declared length running past the data is accepted …
fix(protocols)!: a declared length running past the data is accepted …