Skip to content

fix(pcapng): an NRB record whose name list ends in empty names loses them on rebuild #1383

Closed
#1412
Closed
fix(pcapng): an NRB record whose name list ends in empty names loses them on rebuild#1383
#1412
Labels
fixPull requests that fix a defect (fix: subject prefix)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 7, 2026

An NRB record with data a\0\0 or a\0b\0 does not rebuild byte-exactly: the parse strips trailing NULs, so empty names vanish. main behaves identically. The spec has an open issue about empty strings, so decide whether to keep them. Either way, the raw record bytes must round-trip.

Confirmed by the #1373/#1378 cross-reviews; present on main too, so not a regression of those PRs. Blocked until #1373 and #1378 merge (same PCAP-NG/PCAP modules).

Activity

  1. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 7, 2026
  2. JarryShaw
    added this to PyPCAPKiton Oct 7, 2026

  3. JarryShaw commented on Oct 8, 2026

    @JarryShaw
    JarryShaw
    on Oct 8, 2026
    OwnerAuthor

    Still blocked, now on a different PR. #1378 has merged, but the PCAP-NG half of #1398 (#1325, strict option lengths) is about to edit the same PCAP-NG files. Blocked until #1398 merges.

  4. JarryShaw commented on Oct 8, 2026

    @JarryShaw
    JarryShaw
    on Oct 8, 2026
    OwnerAuthor

    Unblocked: #1398 (and #1400) have merged. One worker is taking all the PCAP-NG follow-ups together, #1382–#1384, #1401, #1405 and #1406, because they edit the same pcapng.py files.

  5. JarryShaw
    added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 8, 2026
  6. JarryShaw
    added a commit that references this issue on Oct 8, 2026

    fix(pcapng)!: PCAP-NG round-trip follow-ups (#1382, #1383, #1384, #1401…

    ec2ba13
  7. JarryShaw
    closed this as completedin #1412on Oct 8, 2026
  8. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
  9. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions