Skip to content

fix(hip): Locator flags drop the seven bits other than Preferred on rebuild #1365

Closed
#1367
Closed
fix(hip): Locator flags drop the seven bits other than Preferred on rebuild#1365
#1367
Labels
fixPull requests that fix a defect (fix: subject prefix)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 7, 2026

HIP Locator.flags (pcapkit/protocols/schema/internet/hip.py:594-599) is a BitField declaring only preferred: (7, 1), so the other seven bits of the octet are dropped on rebuild: flags 0xfe parses and rebuilds through from_data as 0x00. Found by the cross-review of #1342, which fixes four other HIP round trips but not this one.

The other twelve HIP reserved octets that drop their contents (R1_COUNTER :563, NAT_TRAVERSAL_MODE :818, ENCRYPTED :849, NOTIFICATION :1056, REG_FROM :1165, ESP_TRANSFORM :1207, PAYLOAD_MIC :1256, ROUTE_DST :1304, RELAY_FROM :1426, RELAY_TO :1443, OVERLAY_TTL :1458, ROUTE_VIA :1476) are PaddingField sites and belong to #1223.

Name a reserved sub-field for the seven bits, per the #654 per-site policy.

Activity

  1. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Blocked until #1342 merges, because both edit pcapkit/protocols/schema/internet/hip.py.

  2. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 7, 2026

  3. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Unblocked: #1342 merged at 20:11Z. Back to pending.

  4. JarryShaw
    added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  5. JarryShaw
    added this to PyPCAPKiton Oct 7, 2026
  6. JarryShaw
    added a commit that references this issue on Oct 7, 2026

    fix(hip): Locator flags drop the seven bits other than Preferred on r…

    696330e
  7. JarryShaw
    closed this as completedin #1367on Oct 8, 2026
  8. JarryShaw
    added a commit that references this issue on Oct 8, 2026

    fix(hip): Locator flags drop the seven bits other than Preferred on r…

    6455cbc
  9. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
  10. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions