Repository navigation
fix(ipv4): the TS option zeroes the timestamp slots beyond the pointer on rebuild #1349
Description
Describe the bug
The TS option's ts_data covers only pointer - 5 octets; the rest is a PaddingField that packs zeros (pcapkit/protocols/schema/internet/ipv4.py:321 and :326). Slots at or beyond the pointer are data the option carries, and they are lost. Same shape as #1319, which covers LSR/SSR/RR but not TS.
To Reproduce
Parse an IPv4 header carrying the option, then IPv4.from_data(p.info); option bytes in -> out:
- pointer 5:
440c05000000000100000002->440c05000000000000000000 - pointer 9:
44100900000000010000000200000003->44100900000000010000000000000000(slots 2 and 3 of the pre-specified area lost; slot 1 kept)
Expected behavior
The bytes at or beyond the pointer survive the round trip.
Reproduced on main at c9676c5 with /tmp/rtissues/followups-repro.py (check D1).
Found by the PR cross-review follow-up round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at c9676c563.
Activity
JarryShaw commentedon Oct 7, 2026
Blocked until #1344 merges, because both edit
protocols/schema/internet/ipv4.pyandinternet/ipv4.py(the TS sites areschema/internet/ipv4.py:321and:326). #1344 fixes the same zero-fill for LSR/SSR/RR (#1319), so this should follow its shape.JarryShaw commentedon Oct 7, 2026
Unblocked: #1344 has merged. A worker is starting on the TS sites.
fix(ipv4)!: the TS option zeroes the timestamp slots beyond the point…