Repository navigation
fix(schema): iterating a Schema yields keys that __getitem__ refuses, so dict(schema) and .items() raise KeyError #1291
Description
Describe the bug
Schema.__iter__ (schema.py:622-626) yields every non-builtin attribute, including ones post_process sets that are not declared fields, while __getitem__ (:628-632) only serves __fields__ and falls through to super().__getitem__. Same for QuickStartRequestOption and the MPTCP option schemas.
To Reproduce
t = TSOption.unpack(bytes.fromhex("4408090000000001"), 8, None) # pcapkit.protocols.schema.internet.ipv4
list(t) # [..., "remainder", "data", "ts_flag", "timestamp"]
dict(t) # KeyErrort["data"], t["ts_flag"], t["timestamp"] each raise KeyError.
Repro: /tmp/rtissues/corekit-repro.py (check D5) on origin/main 11ae68e.
Expected behavior
Every key yielded by __iter__ is readable through __getitem__ (or __iter__ only yields declared fields).
Found by the corekit round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at 11ae68ebf.
Activity
JarryShaw commentedon Oct 7, 2026
Blocked until the core schema PR for #1274/#1275/#1265/#1285 merges, because both edit
protocols/schema/schema.py.JarryShaw commentedon Oct 7, 2026
Unblocked: #1331 merged at 20:41Z. Back to
pending.fix(schema): Schema.pack keeps option padding, SchemaField spans and …
fix(schema): Schema.pack keeps option padding, SchemaField spans and …