Skip to content

fix(pcapng): epb_verdict may repeat per the spec, but the builder rejects a second one #1281

Closed
#1378
Closed
fix(pcapng): epb_verdict may repeat per the spec, but the builder rejects a second one#1281
#1378
Labels
fixPull requests that fix a defect (fix: subject prefix)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 7, 2026

Describe the bug
The reader accepts several epb_verdict options (no guard near pcapkit/protocols/misc/pcapng.py:2982) but _make_option_epb_verdict has an only-one guard (:5096-5098). The spec lists epb_verdict as allowed multiple times.

To Reproduce
EPB with two 0700 0800 0001020304050607 options: parses 2 verdicts; build from info raises ProtocolError: PCAP-NG: [epb_verdict] option must be only one, but 2 found.

Expected behavior
Both verdicts rebuild. (Independent of #1: that guard is a different, shared-counter bug.)

Found by the misc round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at 11ae68ebf.

Activity

  1. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  2. JarryShaw
    added this to PyPCAPKiton Oct 7, 2026

  3. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Blocked until the PCAP-NG K1-K5 PR (#1267-#1271) merges.

  4. JarryShaw
    added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026

  5. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Unblocked: #1339 merged at 20:42Z. Back to pending.

  6. JarryShaw
    added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  7. JarryShaw
    added a commit that references this issue on Oct 8, 2026

    fix(pcapng): blocks and options rebuild as parsed (#1272, #1273, #1277,

    497a3e9
  8. JarryShaw
    closed this as completedin #1378on Oct 8, 2026
  9. JarryShaw
    added a commit that references this issue on Oct 8, 2026

    fix(pcapng): blocks and options rebuild as parsed (#1272, #1273, #1277,

    4aefe94
  10. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
  11. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions