Skip to content

fix(pcapng): Decryption Secrets Block never pads its secrets data #1279

Closed
#1373
Closed
fix(pcapng): Decryption Secrets Block never pads its secrets data#1279
#1373
Labels
fixPull requests that fix a defect (fix: subject prefix)
Milestone
PyPCAPKit v1.5

Description

@JarryShaw
JarryShaw
opened on Oct 7, 2026

Describe the bug
secrets_length is the unpadded length and the block length adds it without padding (pcapkit/protocols/misc/pcapng.py:3995, :4003), so odd-sized secrets give a block that is not a multiple of 4.

To Reproduce

in  0a000000 18000000 78563412 03000000 01020300 18000000
build from parsed info -> ProtocolError: PCAP-NG: [Block 10] invalid length: 23

Expected behavior
Secrets data is padded to 32 bits with zeros; Secrets Length stays unpadded.

Found by the misc round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at 11ae68ebf.

Activity

  1. JarryShaw
    added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  2. JarryShaw
    added this to PyPCAPKiton Oct 7, 2026

  3. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Blocked until the PCAP-NG K1-K5 PR (#1267-#1271) merges.

  4. JarryShaw
    added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  5. JarryShaw
    added 2 commits that reference this issue on Oct 7, 2026

    fix(pcapng): constructed and rebuilt blocks round-trip (#1267, #1268, #…

    901e123

    fix(pcapng): constructed and rebuilt blocks round-trip (#1267, #1268, #…

    13aa677

  6. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    JarryShaw
    on Oct 7, 2026
    OwnerAuthor

    Unblocked: #1339 merged at 20:42Z. Back to pending.

  7. JarryShaw
    added
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  8. JarryShaw
    closed this as completedin #1373on Oct 8, 2026
  9. JarryShaw
    added a commit that references this issue on Oct 8, 2026

    fix(pcapng): rebuilt blocks keep their lengths and padding (#1276, #1279

    0e25f9f
  10. JarryShaw
    removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
  11. JarryShaw
    added this to the PyPCAPKit v1.5 milestone on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions