fix(tcp): from_data reorders and re-pads TCP options #1151

Activity

1. JarryShaw

   added

   fixPull requests that fix a defect (fix: subject prefix)Pull requests that fix a defect (fix: subject prefix)

   blockedDeferred pending another issue or decision; see the last comment for what unblocks itDeferred pending another issue or decision; see the last comment for what unblocks it

   on Oct 6, 2026
2. JarryShaw commented on Oct 6, 2026

   

   JarryShaw

   on Oct 6, 2026

   OwnerAuthor

   More actions

   Root-cause detail from #1150: TCP._make_tcp_options (tcp.py:2029-2116) drops the original NOP/EOOL octets as "padding" and pads each option to 4 octets separately. Options therefore come back reordered and longer. On http.pcap the data offset goes from a0 to b0, and the IPv4 total length grows by 4.

   A sweep found this in http.pcap, many_interfaces.pcapng, test.pcap and tcp.pcap.
3. JarryShaw

   added this to PyPCAPKiton Oct 6, 2026
4. JarryShaw commented on Oct 6, 2026

   

   JarryShaw

   on Oct 6, 2026

   OwnerAuthor

   More actions

   Unblocked: #1135 merged at 22:31Z, so tcp.py is free. A worker is on it now; it will reproduce the reorder/re-pad independently first, since this was not yet confirmed.
5. JarryShaw

   added

   wipWork in flight - a covering PR is open or an agent is actively on itWork in flight - a covering PR is open or an agent is actively on it

   and removed

   blockedDeferred pending another issue or decision; see the last comment for what unblocks itDeferred pending another issue or decision; see the last comment for what unblocks it

   on Oct 6, 2026
6. JarryShaw

   closed this as completedin #1163on Oct 7, 2026
7. JarryShaw

   removed

   wipWork in flight - a covering PR is open or an agent is actively on itWork in flight - a covering PR is open or an agent is actively on it

   on Oct 7, 2026