Repository navigation
fix(all): pcapkit.all.__all__ omits names its packages export #1136
Description
Describe the bug
pcapkit/all.py maintains __all__ by hand, and the list has gone stale. These names are exported by their packages but missing from pcapkit.all.__all__, so from pcapkit.all import * leaves them out:
- From
pcapkit.protocols:ESP,HTTPv1,HTTPv2,IPv6_ExtandPCAPNG. - From
pcapkit.corekit:EnumRegistry,info_final,MultiDict,OrderedMultiDictandModuleDescriptor. - From
pcapkit.foundation:ReassemblyManager,TraceFlowManagerand sixregister_*callbacks.
git log -S finds no commit that ever added them to all.py. No comment explains their absence, and tests/project/test_public_api.py does not cover pcapkit.all.
Expected behavior
Every public name from the aggregated packages is exported, or its omission is recorded as deliberate, with a test that keeps the list in step.
Blocked until
#1129 merges, because it edits pcapkit/all.py.
Additional context
The #1129 cross-review found this.
Activity
JarryShaw commentedon Oct 6, 2026
Decision needed: should
from pcapkit.all import *export the 11pcapkit.utilitiesnames?The names are
logger,get_logger,configure,reset,ensure_output,warn,stacklevel,detect,beholder,prepareandseekset.#1142 leaves them out because generic names like
warn,resetandconfigureare risky to inject into a caller's namespace. No existing policy decides it: the group was simply commented out in769a17c78(2022-05-29) when the decorators were renamed.all.pyand in the new test.fix(all): pcapkit.all.__all__ omits names its packages export
JarryShaw commentedon Oct 6, 2026
keep them out
JarryShaw commentedon Oct 6, 2026
Ruling from the maintainer: keep the 11
pcapkit.utilitiesnames out offrom pcapkit.all import *. #1142 already does this and records it inall.pyand in the new test.