Skip to content

fix(scapy): the scapy engine fails with format='pcap' #1127

Closed

Description

@JarryShaw

Describe the bug
extract(engine='scapy', format='pcap', ...) raises TypeError: PCAPIO.__init__() missing ... 'protocol' inside ext._ofile(...). Reported by the #1113 reviewer; whether it reproduces on main is unchecked.

Blocked until
#1113 merges, because it edits engines/scapy.py.

System information
main at bdba4fb9d, CPython 3.14.7, Linux.

Additional context
Found by the #1090–#1102 wave's audit and cross-reviews.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 6, 2026
  2. moved this to Blocked in PyPCAPKiton Oct 6, 2026
  3. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 6, 2026
  4. JarryShaw commented on Oct 6, 2026

    @JarryShaw
    OwnerAuthor

    Update from the #1104 fix (#1149). This does not share #1104's cause. Every engine, including the default one, fails with format='pcap'. The failure is at extraction.py:1193, where Extractor.__init__ creates the output writer before any engine or header step has run, so the link type that PCAPIO needs does not exist yet. The fix is to create the writer later.

    Blocked until #1149 merges, because both edit extraction.py.

  5. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 6, 2026
  6. JarryShaw commented on Oct 6, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1113 and #1149 have both merged. A worker is on it now.

  7. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 6, 2026
  8. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions