Repository navigation
Make release Experiments opt-in - #1424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip release Experiments by default.
--with-experimentopts in on each invocation, including resumes. Update the release tests, guide and site descriptions.Closes #1423
Test seams
Evidence
cargo test --test release experiments::releases_skip_experiments_by_default_and_say_so -- --exactfailed withunexpected Experiment call.After: the same command passed, exercising default releases with and without
--review./usr/bin/time -p scripts/affected-tests mainpassed: full Rust suite via the documentedcargo testfallback, all 51 site tests, and 3 release-generator tests. Wall time: 1548.50 seconds, including compilation and all selected checks; the focused release target had been compiled earlier.cargo fmt --check,bash -n scripts/release.sh, andgit diff --check main...HEADpassed.8ee4114163dc18053491e1fbba79da9092db63eb.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Review coverage
Independent Standards and Spec reviews against
maineach read all seven changed files, including generatedsite/docs/index.html. No changed files were left unread; no generated output was excluded.Merge Danger
Door: two-way
Blast Radius: releases
Release Experiments require explicit opt-in; existing CI and version checks remain.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh