Repository navigation
Unit-test git fixtures read the global git config, so tag.gpgsign breaks three tests #1392
Description
Three unit tests fail every time on a machine whose global git config has tag.gpgsign = true:
worktree::synchronization_tests::base_merges_ignore_shadowing_branch_and_tag_namesworktree::synchronization_tests::foreign_observation_and_merge_ignore_shadowing_branch_and_tag_namesworktree::synchronization_tests::spec_catch_up_ignores_shadowing_branch_and_tag_names
git tag origin/main <sha> failed: fatal: no tag message?
With signing on, git tag <name> <commit> makes an annotated, signed tag and asks for a message. Fixture repositories run through Git::run with the developer's global config. The integration tests in tests/support are isolated (GIT_CONFIG_NOSYSTEM), but these unit-test fixtures aren't. So scripts/affected-tests main fails on such a machine whatever the change, including inside a Ticket run there. This was seen on git 2.55.0 while validating #1379, a docs-only change.
Acceptance criteria
- These unit-test fixtures don't read the developer's global or system git config. They set what they need themselves, including user identity and
tag.gpgsign = false, the way the integration tests do. - The three tests pass with
tag.gpgsign = trueandcommit.gpgsign = truein the global config. - No other fixture in
src/relies on the global config.
Activity
JacobStephens2 commentedon Oct 26, 2026
Agent Brief
Category: bug
Summary: Unit-test git fixtures must not read the developer's global or system git config.
Current behavior:
Fixture repositories in unit tests run git through
Git::runwith the developer's own git config. Withtag.gpgsign = true(confirmed in triage on macOS, git 2.55.0, withcommit.gpgsign = truetoo),git tag <name> <commit>creates an annotated signed tag and fails withfatal: no tag message?. That makesworktree::synchronization_tests::*_ignore_shadowing_branch_and_tag_names(three tests) fail on every run on such a machine, whatever the change. The integration tests' support harness already isolates git config (GIT_CONFIG_NOSYSTEMand its own identity); unit-test fixtures don't.Desired behavior:
Every git command a unit-test fixture runs sees only configuration the test sets itself: no global or system config. Fixtures set what they need: user identity,
tag.gpgsign = false,commit.gpgsign = false. ProductionGit::runbehavior for real users is unchanged.Key interfaces:
worktreesynchronization tests, and any other fixture undersrc/that shells out to git.Acceptance criteria:
*_ignore_shadowing_branch_and_tag_namestests pass withtag.gpgsign = trueandcommit.gpgsign = truein the global git config.src/depends on the global or system git config (for example, a globaluser.nameis not needed).cargo testbehaves the same on a machine with no global git config.Out of scope: