refactor(config): single-source configuration metadata and dynamic template generation - #83
Merged
Conversation
…mplate generation - Define PRESETS mapping and CONFIG_SECTIONS_METADATA registry in config.py - Add generate_default_config_template to generate the canonical global TOML configuration - Replace hardcoded template string in cli._ensure_global_config_exists - Simplify apply_preset and _update_dataclass using metadata parser definitions - Add unit tests for dynamic template generation and preset handling in test_config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR establishes a single source of truth for configuration settings, defaults, descriptions, presets, and dynamic TOML template generation:
Single-Source Configuration Metadata:
PRESETSmapping (paranoid,aggressive,balanced,lazy) inconfig.py.CONFIG_SECTIONS_METADATAcontaining field keys, comments, example values, and field parsers (parse_size,parse_time)._update_dataclasswith dynamic lookup inFIELD_PARSERS.DaemonConfig.apply_preset()to look up fromPRESETS.Dynamic Template Generation:
generate_default_config_template() -> strinconfig.py.cli._ensure_global_config_exists()withgenerate_default_config_template().Automated Tests:
tests/test_config.pyvalidating template generation, section coverage, uncommented TOML syntax validity, and preset handling.Verification
ruff check,ruff format,mypy) passing cleanly.