Skip to content

fix(cneinstance): render TMM resources block in sriov mode #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JLCode-tech merged 1 commit into from
Apr 30, 2026
Merged

fix(cneinstance): render TMM resources block in sriov mode #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bnk/cneinstance/manifests/cneinstance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{% set _is_kernel_mode = (tmm_data_plane_mode | default("kernel")) == "kernel" %}
apiVersion: k8s.f5.com/v1
kind: CNEInstance
metadata:
Expand All @@ -16,6 +17,10 @@ spec:
wholeCluster: ${whole_cluster | default(true) | lower}
dpu:
enabled: ${dpu_enabled | default(false) | lower}
{% if not _is_kernel_mode %}
dataPlane:
mode: sriov
{% endif %}
telemetry:
loggingSubsystem:
enabled: true
Expand Down Expand Up @@ -62,7 +67,6 @@ spec:
value: cloud-network-mapping
{% endif %}
tmm:
{% set _is_kernel_mode = (tmm_data_plane_mode | default("kernel")) == "kernel" %}
{% if _is_kernel_mode %}
annotations:
k8s.v1.cni.cncf.io/networks: '[{"name":"${external_nad_name | default("external-netdevice")}","namespace":"${instance_namespace}","interface":"eth1"},{"name":"${internal_nad_name | default("internal-netdevice")}","namespace":"${instance_namespace}","interface":"eth2"}]'
Expand All @@ -71,6 +75,12 @@ spec:
memory: "${tmm_memory | default("6Gi")}"
limits:
memory: "${tmm_memory | default("6Gi")}"
{% else %}
resources:
requests:
memory: "${tmm_memory | default("4Gi")}"
limits:
memory: "${tmm_memory | default("4Gi")}"
{% endif %}
env:
- name: TMM_DEFAULT_MTU
Expand Down
11 changes: 11 additions & 0 deletions bnk/cneinstance/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,17 @@ variable "tmm_default_mtu" {
default = 9000
}

variable "tmm_memory" {
description = "Memory request/limit for TMM container in sriov mode. In kernel mode, use tmm_resources instead. Default 4Gi matches FLO's Small deployment size baseline."
type = string
default = "4Gi"

validation {
condition = can(regex("^[0-9]+(Gi|Mi|Ki|G|M|K)?$", var.tmm_memory))
error_message = "tmm_memory must be a valid Kubernetes memory quantity (e.g., 4Gi, 8192Mi)"
}
}

variable "tmm_ignore_gateways" {
description = "Prevent TMM from using eth0 default gateway (required for SR-IOV setups)"
type = bool
Expand Down
Loading