Repository navigation
fix(toolkit): correct reverse-search boundary and CharSequence equality - #17
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
Check index zero in the reverse-search loop so an otherwise matching prefix is not missed. Preserve the existing starting-index and empty-input handling and add standalone regressions against the complete StringUtil. Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Keep the existing reverse-search correction and null/case policies while comparing builder, buffer and String operands by textual contents. Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com> Assisted-by: OpenAI gpt-6.1-sol
Hanabi9248
force-pushed
the
codex/reverse-search-zero-index
branch
2 times, most recently
from
October 30, 2026 15:44
90938c8 to
c8da512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two public StringUtil API paths return incorrect results for supported inputs:
The fixes are separate commits and regression runners. The equality addition is based on the already published reverse fix; it retains that production hunk byte-for-byte.
Validation:
Run focused equality test: compile the complete class, its four official support classes and tests/StringUtilCharSequenceEqualsRegression.java against the existing Spring Core5.2.10.RELEASE, then run that class. Existing tests/StringUtilReverseSearchRegression.java remains unchanged.
Assisted-by: OpenAI gpt-6.1-sol