feat(SDK-751): add placement IDs to syncMessages - #914
Draft
jferrao-itrbl wants to merge 2 commits into
Draft
jferrao-itrbl wants to merge 2 commits into
jferrao-itrbl wants to merge 2 commits into
Conversation
Expose optional placement scoping on embedded sync so RN matches native Android and iOS APIs; omit/null/empty still syncs all placements.
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (2)
🛟 Help
|
1 new issue
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| ids[i] = (long) placementIds.getInt(i); | ||
| } | ||
| IterableApi.getInstance().getEmbeddedManager().syncMessages(ids); | ||
| } |
jferrao-itrbl
marked this pull request as draft
October 1, 2026 22:01
jferrao-itrbl
changed the title
Lock AC2 sync-all inputs at IterableApi and IterableEmbeddedManager.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🎟️ Jira Ticket: SDK-751
📖 Description
getMessagesalready accepts placement IDs, butsyncMessages()always invoked the no-arg native sync and refreshed every placement. This PR threads an optionalplacementIdsargument through the TurboModule spec, JS façade, and iOS/Android bridges, matching the serialization used bygetEmbeddedMessages. When the argument is omitted, null, or an empty array, behavior is unchanged (sync all placements).🧪 How to test?
yarn lint && yarn typecheck && yarn test --coverageIterable.embeddedManager.syncMessages()and confirm embedded messages still refresh.Iterable.embeddedManager.syncMessages([<placementId>])and verify (native logs / network) that only the requested placement sync runs.🧾 Changelog
Added optional placement IDs to
Iterable.embeddedManager.syncMessages()(SDK-751). When omitted, null, or empty, behavior matches the previous sync-all call. SeeCHANGELOG.mdUnreleased.📹 Loom recording if applicable
N/A
🐞 Github Issues solved
N/A
📚 Docs PR if applicable
N/A