Repository navigation
Move to Atom 5.2.0 - #42
Merged
Merged
Conversation
Uses Atom's Dotnet110X step and Net_11_0 framework label in place of the interim literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WVjNn9JyaJVwymS3qRBSz1
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the Atom 5.2.0 upgrade and adoption of its built-in .NET 11 helpers.
No open issues 🎉
What changed in this PR
Updates the Atom build tooling from 5.0.0 to 5.2.0 and adopts its built-in .NET 11 helpers, preserving the existing workflow configuration.
Changes:
- Upgrades the Atom GitHubWorkflows and GitVersion modules to 5.2.0.
- Replaces literal .NET 11 SDK and test-framework values with Atom’s typed helpers.
| File | Description |
|---|---|
_atom/IBuild.cs |
Uses Atom’s built-in .NET 11 SDK helper and framework constant. |
_atom/_atom.csproj |
Upgrades both Atom module references to 5.2.0. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dec · project thread
Before: The build used Atom 5.0.0, so the .NET 11 SDK step and the net11.0 test framework were written as plain literals (
new SetupDotnetStep("11.0.x")and"net11.0").After: The build uses Atom 5.2.0 and its built-in
BuildOptions.Steps.SetupDotnet.Dotnet110X()andWorkflowLabels.Dotnet.Framework.Net_11_0. The generated workflows are unchanged.How: I bumped
Invex.Atom.Module.GitHubWorkflowsandInvex.Atom.Module.GitVersionto 5.2.0 in_atom/_atom.csproj, swapped the two literals in_atom/IBuild.cs, and ranGen, which produced no workflow diff. Locally, the Release build gives 0 warnings and 0 errors, and the tests pass on net10.0 (48) and net11.0 (50).Generated by Claude Code