Repository navigation
fix(builders): count signers only for required native scripts - #600
Open
penielgold-hub wants to merge 1 commit into
Open
penielgold-hub wants to merge 1 commit into
penielgold-hub wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix fee estimation so fake signer witnesses are added only for native scripts the transaction actually requires.
Previously,
buildFakeWitnessSetcounted required signers for every native script carried by reference inputs or spent inputs, even when the transaction did not use those scripts. That could overestimate the transaction size and fee.This change:
Tests
Verified locally:
git diff --check: passedCloses #596