DO NOT MERGE: Adapt to cardano-api changes - #1417
Draft
erikd wants to merge 2 commits into
Draft
Conversation
erikd
requested review from
Jimbo4350,
carbolymer,
disassembler,
kevinhammond,
newhoggy and
palas
as code owners
August 14, 2026 04:14
erikd
marked this pull request as draft
August 14, 2026 04:14
erikd
force-pushed
the
erikd/crypton-ram
branch
from
August 14, 2026 04:22
0e1e628 to
5b3feaa
Compare
…ation 1.2
cardano-api's b53b1ed2f (upstream, already merged, unrelated to crypton)
replaced caseShelleyToAllegraOrMaryEraOnwards, caseShelleyToMaryOrAlonzoEraOnwards,
and caseShelleyToAlonzoOrBabbageEraOnwards with forEraInEon/Convert; this port
mirrors that at cardano-cli's own three call sites (TxOut.hs, two Option.hs, and
Query/Run.hs).
Also replaces Data.Validation's removed liftError (Read/DRep.hs,
Read/Committee/{Hot,Cold}Key.hs) with Either.either (Failure . return) Success,
the direct equivalent for the 1.1 -> 1.2 breaking rewrite (same one already
fixed in cardano-api's own Sign.hs).
erikd
force-pushed
the
erikd/crypton-ram
branch
from
September 2, 2026 03:09
5b3feaa to
9872149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental PR for testing the crypton/memory/ram change over.