fix: enforce weights-only loading for MemDecode router checkpoints - #4988
Merged
lvhan028 merged 1 commit intoSep 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing weights_only=True usage elsewhere in the repo, and directly addresses safer checkpoint loading without altering broader control flow.
Pull request overview
This PR hardens MemDecode router checkpoint loading by forcing PyTorch .pt router checkpoints to be deserialized using PyTorch’s weights-only pathway, reducing the risk of unsafe/unintended pickle object loading.
Changes:
- Load
.ptrouter checkpoints withtorch.load(..., weights_only=True)when extracting router config. - Load
.ptrouter checkpoints withtorch.load(..., weights_only=True)when extracting the router state dict.
File summaries
| File | Description |
|---|---|
| lmdeploy/pytorch/memdecode/fusion.py | Enforces weights-only deserialization for .pt router checkpoint reads (config + state dict). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.