Skip to content

fix(api): allow subscribing to all webhook events - #200

Open
ruizink wants to merge 1 commit into
Interhyp:mainfrom
ruizink:fix-allow-all-wh-events
Open

ruizink wants to merge 1 commit into
Interhyp:mainfrom
ruizink:fix-allow-all-wh-events

Conversation

@ruizink

@ruizink ruizink commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Description

The implementation of the WebhooksSpec.events field does not match the documentation.

The docs state:

If empty, the webhook subscribes to all events ("*").

But there's a unit test that makes sure that the default is push (It("should default to push event", func() {). This matches GitHub's default value, which is quite intuitive.

Instead of changing the default, which would be a breaking change and would drift from GitHub's default, add the option of specifying * for subscribing to all events. This is allowed by GitHub's API.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Chore (refactoring, CI changes, dependency updates, etc.)

Checklist

  • My commits follow the Conventional Commits format
  • I have added/updated unit tests for any new or changed templates
  • I have updated documentation (README, CONTRIBUTING, values comments) if needed
  • I have updated the generated files using make codegen

Related Issues

Fixes: #199

Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
@ruizink
ruizink requested a review from a team as a code owner November 13, 2026 12:43
@tstollin

Copy link
Copy Markdown
Contributor

Hi @ruizink,

Thanks a lot for your contribution. I will take a look at it after the weekend. :)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[api] webhooks spec doesn't allow you to subscribe to all events

2 participants