Repository navigation
ci: install conda with setup-miniconda in the Linux conda jobs - #403
Open
jharlow-intel wants to merge 1 commit into
Open
jharlow-intel wants to merge 1 commit into
jharlow-intel wants to merge 1 commit into
Conversation
ubuntu-latest is now Ubuntu 26.04, whose image no longer ships Miniconda, so $CONDA is unset and the Linux build and test jobs failed with 'conda: command not found'. Use setup-miniconda, as the Windows jobs already do, and pass the cached pkgs_dirs through its pkgs-dirs input (it rewrites ~/.condarc). Same as IntelPython/mkl_random#207.
jharlow-intel
requested review from
antonwolfy,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 28, 2026 22:19
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Linux conda workflow updates.
No open issues 🎉
What changed in this PR
Updates the Linux conda workflows to install Miniforge explicitly rather than relying on Miniconda being preinstalled on the runner.
Changes:
- Uses
setup-minicondain all four Linux build and test jobs. - Preserves the cached package directory through
pkgs-dirs. - Derives build and artifact paths from
CONDAinstead of hardcoded installation paths.
Repository guidance could not be verified because /repo/AGENTS.md was unavailable.
| File | Description |
|---|---|
.github/workflows/conda-package.yml |
Installs Miniforge, configures the package cache, and derives CONDA_BLD from CONDA. |
.github/workflows/conda-package-cf.yml |
Installs Miniforge, configures the package cache, and derives the artifact path from CONDA. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntu-latestmoved from Ubuntu 24.04 to 26.04 around 25 October, and the 26.04 image no longer ships Miniconda.$CONDAis unset, so "Add conda to system path" adds/bin, and the Linux build and test jobs inconda-package.ymlandconda-package-cf.ymlfail withconda: command not found(Conda package, Conda package using conda-forge). The same image change removedapt-key, which #402 fixes. Same change as IntelPython/mkl_random#207.conda-incubator/setup-miniconda, as the Windows jobs already do. It addscondabintoPATH, exports$CONDAand setsalways_yes, so the existingcondasteps run unchanged.~/.condarcwhen it starts, so the separate "Set pkgs_dirs" steps would be lost;pkgs-dirs: ~/.conda/pkgskeeps the cached package directory instead.CONDA_BLDinconda-package.ymland the artifact path inconda-package-cf.ymlpointed at the old image's/usr/share/miniconda; both now come from$CONDA.pre-commitpasses on both files, andzizmorreports the same findings as onmaster.