Skip to content

chore(deps): pin waveflow-core to v2.1.0 - #449

Merged
InstaZDLL merged 1 commit into
mainfrom
chore/core-2-1-0
Nov 14, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
chore/core-2-1-0

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Moves the waveflow-core pin from v2.0.0 to v2.1.0 (30f21b89). This is step 0 of RFC-029: the RFC's scanner work needs waveflow_core::scanner::clips, which this release adds. Nothing in the server uses that module yet.

What the server calls, and what moved

Compared with git diff v2.0.0 v2.1.0 -- src-tauri/crates/core, limited to what src/ and tests/ call:

  • extract_cover changes in two ways, for a file read from now on:
    • an empty picture is skipped in the fallback too (WaveFlow #1071);
    • the format comes from the bytes (JPEG, PNG, WebP) before the declared MIME type. A WebP thumbnail declared image/jpeg, or with no MIME at all, is stored as .webp. It used to be stored as .jpg, or as .bin, which artwork_mime never serves.
  • Unchanged:
    • canonical_name, so no derived album or artist id moves;
    • AUDIO_EXTENSIONS, so NOT_YET_INDEXED stays as it is;
    • text_encoding, so the copy in encoding_read_as stays aligned;
    • lofty's version, so there is still only one lofty in the graph;
    • the hashing, the analysis and the thumbnails.
  • Not called by the server:
    • the artist identity by MusicBrainz id (artist_credit_with_ids, upserts);
    • the tag workshop;
    • scanner::clips.

Known limit

apply.rs writes an artwork row with ON CONFLICT (hash) DO NOTHING. A cover already in the catalogue therefore keeps the format its row was written with, even through database rescan-full. That includes a WebP stored as bin, which stays unserved. The core writes the correctly named file beside the old one, but the row does not point at it. The desktop corrects such rows on its next scan, and the server does not do that yet. The CHANGELOG entry says this.

Checks

  • cargo fmt --all --check, cargo clippy --all-targets --all-features -D warnings, cargo doc with -D warnings and scripts/check-rust-layout.sh: all pass.
  • cargo test --all-features: 846 passed, 0 failed, over 26 binaries.

Summary by CodeRabbit

  • Améliorations
    • La sélection d’une image de couverture de remplacement privilégie désormais la prochaine image non vide.
    • Le format des couvertures est détecté à partir de leur contenu avant de tenir compte du type MIME déclaré. Les couvertures déjà cataloguées conservent leur format lors d’un rescan si leur contenu n’a pas changé.
  • Maintenance
    • Mise à jour de waveflow-core vers la version 2.1.0.

Signed-off-by: InstaZDLL <github.105mh@8shield.net>
@github-actions github-actions Bot added scope: server Server core (Rust) scope: deps Dependencies scope: docs Docs, README, assets ignore-for-release Excluded from release notes labels Nov 14, 2026
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

waveflow-core passe de la balise v2.0.0 à v2.1.0. Le changelog décrit les changements de cette version concernant la sélection et le format des couvertures.

Changes: Mise à jour de waveflow-core

Layer / File(s) Summary
Dépendance et note de version
Cargo.toml, CHANGELOG.md
Cargo.toml référence waveflow-core à la balise v2.1.0, sans modifier son URL Git ni default-features = false. Le changelog décrit les changements de cette version concernant les couvertures et les éléments qui restent inchangés.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested labels: scope: deps

Merge Risk: Minimal · up to 4e12d

This updates the waveflow-core dependency to v2.1.0, which improves cover selection and format detection. No concrete merge-blocking risk was found. Existing catalog covers keep their stored format after a rescan, and the changelog documents this.

Architecture risk: Low · up to 4e12d

The change affects 2 systems.

Changed systems: Cargo.toml, CHANGELOG.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Cargo.toml (service) was modified; 1 changed file maps to changed impact.
  • observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CHANGELOG.md: Ajout d’une entrée Changed pour la version non publiée : waveflow-core passe de v2.0.0 à v2.1.0. Le changelog décrit le recours à la prochaine image non vide quand la première ne fournit pas de couverture, puis la priorité du format reconnu dans les octets (JPEG, PNG, WebP) sur le MIME déclaré. Les couvertures déjà présentes en catalogue gardent le format de leur ligne, non réécrite lors d’un rescan complet si le hash du contenu sert à l’adresser. Le texte indique également que les autres changements de la dépendance ne sont pas appelés par le serveur et que plusieurs éléments restent inchangés.
  • observed — Modified behavior in Cargo.toml: La dépendance waveflow-core passe de la balise v2.0.0 à v2.1.0; son URL Git et la désactivation des fonctionnalités par défaut sont conservées.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed Le titre « chore(deps): pin waveflow-core to v2.1.0 » décrit le changement principal : la dépendance Git waveflow-core passe de v2.0.0 à v2.1.0 dans Cargo.toml. Le titre est court, précis et sans brui…
Description check Passed La description suit le modèle pour l'essentiel. Le résumé dit la mise à jour de l'épingle et le lien avec RFC-029. La section « Changes » décrit les changements substantiels sur extract_cover, les élé…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

Le titre « chore(deps): pin waveflow-core to v2.1.0 » décrit le changement principal : la dépendance Git waveflow-core passe de v2.0.0 à v2.1.0 dans Cargo.toml. Le titre est court, précis et sans bruit. Il ne mentionne pas les changements de comportement de extract_cover, mais ce n'est pas requis.

Full details: Description check

Explanation

La description suit le modèle pour l'essentiel. Le résumé dit la mise à jour de l'épingle et le lien avec RFC-029. La section « Changes » décrit les changements substantiels sur extract_cover, les éléments inchangés et les modules non utilisés. Une section « Notes » contient la limite connue. La checklist de test est remplacée par une section « Checks » en prose : les commandes cargo sont listées avec leur résultat, mais les commandes bun du modèle ne sont pas mentionnées, ce qui est acceptable pour un dépôt Rust. La confirmation AGPL-3.0-only et DCO n'apparaît pas dans la description. Le contenu est donc presque complet.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f51fca9 and 4e12d99.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock, !Cargo.lock, !*.lock
Files selected for processing: 2

  • CHANGELOG.md
  • Cargo.toml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@github-actions github-actions Bot added size: s 10-50 lines ignore-for-release Excluded from release notes and removed ignore-for-release Excluded from release notes labels Nov 14, 2026
@InstaZDLL InstaZDLL self-assigned this Nov 14, 2026
@InstaZDLL
InstaZDLL merged commit 535c6c1 into main Nov 14, 2026
17 checks passed
@InstaZDLL
InstaZDLL deleted the chore/core-2-1-0 branch November 14, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Excluded from release notes scope: deps Dependencies scope: docs Docs, README, assets scope: server Server core (Rust) size: s 10-50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant