Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ ENABLE_EXPLANATIONS=true
# Affiche le bloc "Bonnes pratiques minimales" (accueil) et leurs controles sur les
# tokens obtenus (page de resultat).
ENABLE_RECOMMANDATIONS=true
# Affiche le bouton "Copier l'access_token" sur la page de resultat. A false, les
# tokens sont aussi masques dans les sections "Tokens bruts" et "Echanges HTTP".
COPY_BUTTON=false
# Optionnel : pre-remplit le champ ACR de l'UI (modifiable a chaque login sans redeployer).
ACR_VALUES=
ACR_ESSENTIAL=false
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ variables `ACR_VALUES`/`ACR_ESSENTIAL` ne servent qu'à pré-remplir ce champ.
| `ENABLE_DPOP` | non | `false` | Active DPoP (RFC 9449) sur le token endpoint et `/userinfo` |
| `ENABLE_EXPLANATIONS` | non | `true` | Affiche les sections pédagogiques de l'UI : "Échanges HTTP", "Comprendre PKCE", "Comprendre DPoP" et les panneaux de valeurs PKCE/DPoP de la tentative |
| `ENABLE_RECOMMANDATIONS` | non | `true` | Affiche le bloc "Bonnes pratiques minimales — Clients OIDC Keycloak" sur la page d'accueil, et le panneau "Contrôle des bonnes pratiques" appliqué aux tokens obtenus sur la page de résultat |
| `COPY_BUTTON` | non | `false` | Affiche le bouton "📋 Copier l'access_token" sur la page de résultat. A `false`, les tokens bruts (`access_token`, `id_token`, `refresh_token`) sont aussi masqués dans les sections "Tokens bruts" et "Échanges HTTP" |
| `ACR_VALUES` | non | — | Pré-remplit le champ `acr_values` de l'UI (modifiable à chaque login) |
| `ACR_ESSENTIAL` | non | `false` | Pré-coche la case "exiger strictement" de l'UI |
| `PUBLIC_BASE_URL` | oui | — | URL publique du service (sert à construire le `redirect_uri` : `PUBLIC_BASE_URL/callback`) |
Expand Down
5 changes: 5 additions & 0 deletions app/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ class Settings(BaseSettings):
"Affiche les bonnes pratiques OIDC (accueil) et leurs controles sur les tokens obtenus (resultat)"
),
)
copy_button: bool = Field(
default=False,
description="Affiche le bouton 'Copier l'access_token' sur la page de resultat",
)
acr_values: str | None = Field(
default=None,
description=(
Expand Down Expand Up @@ -112,6 +116,7 @@ def redacted(self) -> dict:
"enable_dpop": self.enable_dpop,
"enable_explanations": self.enable_explanations,
"enable_recommandations": self.enable_recommandations,
"copy_button": self.copy_button,
"acr_values": self.acr_values,
"acr_essential": self.acr_essential,
"http_verify_tls": HTTP_VERIFY_TLS,
Expand Down
10 changes: 10 additions & 0 deletions app/httplog.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

SENSITIVE_HEADER_NAMES = {"authorization"}
SENSITIVE_BODY_FIELDS = {"client_secret"}
# Masques dans l'UI uniquement quand COPY_BUTTON=false.
TOKEN_FIELDS = {"access_token", "refresh_token", "id_token"}
# Masques uniquement dans les logs : l'UI doit pouvoir les afficher.
LOG_ONLY_SENSITIVE_BODY_FIELDS = {"access_token", "refresh_token", "id_token", "code", "code_verifier"}

Expand Down Expand Up @@ -59,6 +61,14 @@ def _redact_for_log(entry: dict[str, Any]) -> dict[str, Any]:
}


def redact_tokens(transcript: list[dict]) -> list[dict]:
"""Copie du transcript avec les tokens masques, pour l'UI quand COPY_BUTTON=false."""
body_keys = ("request_body", "response_body")
return [
{k: (redact_body(v, TOKEN_FIELDS) if k in body_keys else v) for k, v in e.items()} for e in transcript
]


def _safe_response_body(response: httpx2.Response) -> Any:
try:
return response.json()
Expand Down
13 changes: 9 additions & 4 deletions app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from .checks import run_checks
from .config import HTTP_VERIFY_TLS, get_settings
from .dpop import generate_dpop_jwk, jwk_thumbprint, public_jwk
from .httplog import configure_logging, record_exchange
from .httplog import TOKEN_FIELDS, configure_logging, record_exchange, redact_body, redact_tokens
from .oidc import (
build_authorization_url,
build_logout_url,
Expand Down Expand Up @@ -83,6 +83,11 @@ def _render_error(request: Request, error: str, error_description: str, status_c
)


def _ui_transcript(transcript: list[dict]) -> list[dict]:
"""Transcript a afficher : tokens masques si le bouton de copie est desactive."""
return transcript if settings.copy_button else redact_tokens(transcript)


def _annotate_dpop_proofs(transcript: list[dict]) -> None:
"""Decode chaque preuve DPoP presente dans les headers de requete du transcript,
pour affichage pedagogique (header + payload) a cote de chaque echange HTTP."""
Expand Down Expand Up @@ -223,7 +228,7 @@ async def callback(
"result.html",
{
"config": settings.redacted(),
"transcript": transcript,
"transcript": _ui_transcript(transcript),
"success": False,
"token_error_status": token_response.status_code,
"pkce_info": pkce_info,
Expand Down Expand Up @@ -320,10 +325,10 @@ async def callback(
"result.html",
{
"config": settings.redacted(),
"transcript": transcript,
"transcript": _ui_transcript(transcript),
"success": True,
"acr_essential_unmet": acr_essential_unmet,
"tokens": tokens,
"tokens": tokens if settings.copy_button else redact_body(tokens, TOKEN_FIELDS),
"decoded": decoded,
"userinfo": userinfo,
"generated_at": time.strftime("%Y-%m-%d %H:%M:%S"),
Expand Down
2 changes: 1 addition & 1 deletion app/templates/result.html
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ <h2>JWT décodés</h2>
<summary>
<span class="step">{{ name }}</span>
<span style="margin-left: auto; display: flex; align-items: center; gap: 0.5rem;">
{% if name == 'access_token' %}
{% if name == 'access_token' and config.copy_button %}
<button type="button" class="btn-copy" onclick="tokenlabCopyToken(event, this)" data-token="{{ tokens[name] }}">📋 Copier l'access_token</button>
{% endif %}
{% if content.signature %}
Expand Down
1 change: 1 addition & 0 deletions k8s/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ data:
ENABLE_DPOP: "false"
ENABLE_EXPLANATIONS: "true"
ENABLE_RECOMMANDATIONS: "true"
COPY_BUTTON: "false"
# URL publique par laquelle les utilisateurs (et le navigateur, pour le redirect_uri) atteignent ce service
PUBLIC_BASE_URL: "https://tokenlab.mon-cluster.example.com"
LOG_LEVEL: "INFO"
Loading