chore: add warning for nodePool validation

[kerthcet]

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

Summary by CodeRabbit

• New Features
  • NodePool validation now warns when a known provider does not support the requested capacity tier or egress mode, and when no known provider can place Pods with the requested settings.
  • NodePools using Modal with Spot capacity are no longer rejected during validation.
• Bug Fixes
  • Placement now consistently checks provider support for capacity tiers and egress policies.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 82edef16-cf0b-4d05-8d29-53a42a55507d

📥 Commits

Reviewing files that changed from the base of the PR and between c605d6c and c1d4e29.

📒 Files selected for processing (5)

• internal/controller/pod_placement_helpers.go
• internal/webhook/v1/nodepool_webhook.go
• internal/webhook/v1/nodepool_webhook_test.go
• pkg/provider/catalog/base.go
• pkg/provider/provider.go

 ___________________________________________________________________________
< In Vino Veritas, In Codice Bugas. In wine, there is truth; in code, bugs. >
 ---------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot review overview

🟡 Changes recommended

The user-facing admission change needs the release note required by the PR template.

Review effort: Balanced
Findings: 1

Open (1)

• Missing release note for NodePool admission behavior change · New

What changed in this PR

Adds admission warnings for NodePool configurations that registered providers cannot serve.

Changes:

• Centralizes capacity-tier and egress capability checks.
• Warns instead of rejecting unsupported configurations.
• Adds webhook warning tests.

File	Description
pkg/​provider/​provider.go	Adds capability-check helpers.
pkg/​provider/​catalog/​base.go	Updates helper reference.
internal/​webhook/​v1/​nodepool_webhook.go	Generates NodePool warnings.
internal/​webhook/​v1/​nodepool_webhook_test.go	Tests warning scenarios.
internal/​controller/​pod_placement_helpers.go	Uses centralized checks.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[kerthcet]

/lgtm
/kind cleanup

[InftyAI-Agent]

Approved: PR has both lgtm and approved labels

[InftyAI-Agent]

Approved: PR has both lgtm and approved labels

[InftyAI-Agent]

Approved: PR has both lgtm and approved labels