Skip to content

fix: resolve #118 Add webhook for nodePool #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chenzeyan54-commits wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: resolve #118 Add webhook for nodePool #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions api/v1alpha1/nodepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ import (
// UNREACHABLE (the Strategy enum admits only Ordered), kept so widening the enum
// cannot ship without its weight validation.
// +kubebuilder:validation:XValidation:rule="self.strategy != 'Weighted' || self.providers.all(p, has(p.weight))",message="strategy Weighted requires a weight on every provider"
// The CEL rule below enforces that Modal is never paired with Spot capacity: Modal does
// not support spot instances, so admitting such a pool would let it claim a policy it
// cannot honour. The guard checks the user-supplied list only; the API default fills
// capacityTypes with [OnDemand, Spot] when omitted, and that default already satisfies
// this rule for any pool that does not list Spot explicitly.
// +kubebuilder:validation:XValidation:rule="!(self.providers.exists(p, p.name == 'modal') && has(self.capacityTypes) && self.capacityTypes.exists(c, c == 'Spot'))",message="Modal does not support spot instances; remove Modal from providers or remove Spot from capacityTypes"
// (AWS once required at least one region here, because an omitted list meant "the
// client's default region" and its client has none. Omitted now means "every region
// the provider serves", which is a valid — if broad — AWS policy, so the rule is gone.
Expand Down Expand Up @@ -272,11 +278,11 @@ type NodePool struct {

// NodePoolList contains a list of NodePool.
type NodePoolList struct {
metav1.TypeMeta `json:",inline"`
metav1.TypeMeta `json:", inline"`
metav1.ListMeta `json:"metadata,omitempty"`
Items []NodePool `json:"items"`
}

func init() {
SchemeBuilder.Register(&NodePool{}, &NodePoolList{})
}
}
Loading