A successful Job will most likely read as Failed.

[kerthcet]

What happened:

As the title mentioned, a Pod succeeded with exit code == 0 will be marked as Failed, which is not right.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

[kerthcet]

/milestone v0.2.0

[kerthcet]

/help

[Sarthak-Shreshtha01]

I skip reaping Pods in the Succeeded phase in the pod placement helpers, so a finished Job no longer reads as Failed. I added a test for it in the pod placement controller tests. (PR: #128)

[kerthcet]

Hi @Sarthak-Shreshtha01 thanks for your interest, I think this is more complex than just skipping reaping Pods.

• I agree we should not delete the succeeded and failed Pods since the corresponding instances are already terminated for most of the cases
• Exit codes aren't recorded, every terminated instances is marked as Failed, that's the main problem for this issue. We should tell them apart, if exitcode is 0, succeeded, else, failed
• We should add validation to the Job, only allow restartPolicy == Never, because we don't support restart the container

More advanced:

• to avoid potential instance leak, once we have succeeded and failed Pods, we may still need to call the termination API but don't delete the Pods, let the Job controller to manage them.

We may have more gaps to support Job here but we can optimize them step by step.