Repository navigation
mwm and RRSI: refuse a learner backend other than Codex or Claude Code at setup - #92
Draft
iamziyuzhao wants to merge 1 commit into
Draft
iamziyuzhao wants to merge 1 commit into
iamziyuzhao wants to merge 1 commit into
Conversation
…e at setup mwm ran a Pi learner without its bound model (its session settings carry no provider), and RRSI's roles, kept read-only through Codex's own sandbox mode or Claude Code's tool settings, ran with all of Pi's tools. Both now refuse an evolver.params.backend other than codex or claude before the first step. Each test fails without its check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
evolver.base: piloads for every AgentEvolver-based method, but two of them cannot drive a Pi session:provider(MwmEvolver._settings), so a Pi session ranwithout its bound model. Its texts, homes and sign-ins are Codex's or Claude Code's.
(
codex_sandbox: read-only) or Claude Code's tool settings (allowed_tools,text_only). Pi reads none of these,so on Pi the roles ran with all of Pi's tools.
Both now refuse an
evolver.params.backendother thancodexorclaudeinsetup, before the first step.Found while adding DeepSeek Harness (#90), whose
dshbackend these methods cannot drive either, and split out ofit so that #90 changes only dsh. #90 refuses
dshon the same two lines; whichever merges second keeps this check,which covers both.
Validation
tests/methods/mwm/test_mwm_evolver.py::test_a_learner_that_is_not_codex_or_claude_code_is_refused_at_setupandtests/methods/rrsi_adapter/test_rrsi_adapter.py::test_setup_checks_what_every_step_needs(therrsidependencygroup installed):
backend: piis refused at setup.--integration, with therrsigroup: 2 failed, 1230passed, 80 skipped. On
mainthe same run gives 2 failed, 1229 passed, 80 skipped: the same two tests, which failas root (
test_isolate::test_a_rollout_sees_what_is_declared_and_nothing_else,test_ahe_hook_runner::test_logs_that_cannot_be_written_lose_the_line_not_the_call).Review
unchanged, already right:
docs/methods/mwm.mdnames its learner as Codex or Claude Code, anddocs/methods/rrsi_adapter.mdits proposer and roles ascodexorclaudesessions.learner for these two methods is refused with the backends they take.
setup.naming the backends it takes, instead of running each step without its model or its read-only roles.
🤖 Generated with Claude Code