Repository navigation
Stop a CLI session's processes on macOS too - #88
Merged
haizhongzheng merged 3 commits intoNov 9, 2026
Merged
haizhongzheng merged 3 commits into
haizhongzheng merged 3 commits into
Conversation
The processes below a session were found through /proc, which macOS lacks, so one in a session of its own was never stopped; they are now found with ps there. On macOS, signalling a group left with only exited, unreaped processes raises PermissionError; it now means the group has ended, in the Base Agent's stop and in the AgentDyn runner's and the Lean swarm launcher's.
…reads a process's state on macOS too
ruiling-smartbear
marked this pull request as draft
November 8, 2026 05:17
ruiling-smartbear
marked this pull request as ready for review
November 9, 2026 18:14
…back on Linux too - an exited, unreaped grandchild (under a subreaper, or a container's PID 1 that does not reap) is stopped, not a survivor - parametrized proc / ps: CI on Linux now runs the macOS ps fallback; the ps case fails without it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
On macOS a CLI session stopped at its timeout or on cancel could leave processes running or fail (
hermit/agent/base/cli.py, core):_stopfound the processes below a session through/proc, which macOS lacks._parents()now usespsthere; Linux is unchanged.os.killpgon a group of exited, unreaped processes raisesPermissionErroron macOS. It now means the group ended whenproc.poll()shows the session exited; otherwise it is raised. The same in the AgentDyn and Lean swarm stops.Left as before:
evolver/agent.pyandharbor/runner.pycallkillpgwithout this handling.Validation
tests/core/test_cli_agent.py::test_a_stopped_session_takes_a_descendant_in_a_session_of_its_own: fails without the change on macOS. The AgentDyn test now checks for survivors on macOS too.python -m pytest --changedon macOS: 10 failed (vs 13 onmain; the other 10 need bubblewrap or/proc).Review
_stopand_descendantsinhermit/agent/base/cli.py, as above.cfca793: no blocking findings; test cleanup and the AgentDyn check fixed in the next commit.