fix(drag-drop): disable drag on secondary pointer button - 21.2.x - #17523
Open
igdmdimitrov wants to merge 1 commit into
Open
fix(drag-drop): disable drag on secondary pointer button - 21.2.x#17523igdmdimitrov wants to merge 1 commit into
igdmdimitrov wants to merge 1 commit into
Conversation
igdmdimitrov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #17424 by preventing the igxDrag directive from initiating drag interactions when the user presses a non-primary mouse/pointer button (e.g., right click), avoiding unintended drag/click behavior in components that rely on igxDrag (such as chips and grid row dragging).
Changes:
- Added an early return in
IgxDragDirective.onPointerDownto only start drag on the primary pointer/mouse button. - Added a unit test to ensure drag is not initiated on a secondary pointer button.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/directives/src/directives/drag-drop/drag-drop.directive.ts | Adds a guard to ignore non-primary button presses when starting a drag. |
| projects/igniteui-angular/directives/src/directives/drag-drop/drag-drop.spec.ts | Adds a pointer-button test to validate the new behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
2005
to
+2006
|
|
||
| it('should not initiate drag on secondary pointer button', async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17424
Description
Modifying drag-drop directive to start drag only on primary mouse button
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)