fix(drag-drop): disable drag on secondary pointer button - 22.0.x - #17522
Open
igdmdimitrov wants to merge 1 commit into
Open
fix(drag-drop): disable drag on secondary pointer button - 22.0.x#17522igdmdimitrov wants to merge 1 commit into
igdmdimitrov wants to merge 1 commit into
Conversation
igdmdimitrov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #17424 by preventing IgxDragDirective from initiating drag interactions when the user presses a non-primary pointer button (e.g., right click), which previously could trigger drag/click behavior and then show the browser context menu.
Changes:
- Added an early-return guard in
IgxDragDirective.onPointerDownto only start drag handling for the primary button. - Added a unit test to verify that a secondary-button
pointerdowndoes not start dragging, emit drag events, or create a ghost element.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/directives/src/directives/drag-drop/drag-drop.directive.ts | Adds a primary-button check in onPointerDown to prevent drag initiation on secondary button presses. |
| projects/igniteui-angular/directives/src/directives/drag-drop/drag-drop.spec.ts | Adds coverage to ensure secondary-button pointer input does not initiate drag/click behavior. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2006
to
+2010
| it('should not initiate drag on secondary pointer button', async () => { | ||
| const firstDrag = fix.componentInstance.dragElems.first; | ||
| const firstElement = firstDrag.element.nativeElement; | ||
| const startingX = (dragDirsRects[0].left + dragDirsRects[0].right) / 2; | ||
| const startingY = (dragDirsRects[0].top + dragDirsRects[0].bottom) / 2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17424
Description
Modifying drag-drop directive to start drag only on primary mouse button
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)