Repository navigation
EnumCast: Use ::tryFrom in fromDb() - #177
Merged
Merged
Conversation
BastianLedererIcinga
requested changes
Oct 16, 2026
Schema changes may remove or add new values to an enum, so existing rows should not throw an exception. The consumer is supposed to ensure only valid values are persisted, hence toDb() still throws. Existing rows have to be seen as always valid, though.
nilmerg
force-pushed
the
enumcast-tryfrom
branch
from
October 16, 2026 13:32
a60b312 to
206940b
Compare
BastianLedererIcinga
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema changes may remove or add new values to an enum, so existing rows should not throw an exception. The consumer is supposed to ensure only valid values are persisted, hence toDb() still throws. Existing rows have to be seen as always valid, though.