Skip to content

container: allow projects to skip QEMU setup step - #28

Merged
yhabteab merged 1 commit into
mainfrom
skip-qemu
Oct 23, 2026
Merged

yhabteab merged 1 commit into
mainfrom
skip-qemu

Conversation

@yhabteab

Copy link
Copy Markdown
Member

Not to break existing users of this template (like Icinga 2), it's on by default, any other project that want to skip this step must explicitly say so.

@jrauh01 this is very similar to this PR of yours Icinga/icinga-kubernetes#275. I'm planning to use this template for Icinga Notifications docker build actions, so would be nice if you could have a look at this.

@yhabteab
yhabteab requested a review from jrauh01 October 23, 2026 08:54
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Oct 23, 2026
@yhabteab

Copy link
Copy Markdown
Member Author

@jrauh01 jrauh01 left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks solid. The header should be definitely adjusted, the remaining two changes I would consider as optional.

Comment thread .github/workflows/container-image.yml Outdated
Comment thread .github/workflows/container-image.yml Outdated
Comment thread .github/workflows/container-image.yml Outdated
Not to break existing users of this template (like Icinga 2), it's on by
default, any other project that want to skip this step must explicitly
say so.

@jrauh01 jrauh01 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhabteab
yhabteab merged commit 2502ca6 into main Oct 23, 2026
13 checks passed
@yhabteab
yhabteab deleted the skip-qemu branch October 23, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants