[WIP] Move to GradedArrays 0.16 and TensorAlgebra 0.19.3, simplify named broadcasting - #243
Draft
mtfishman wants to merge 9 commits into
Draft
[WIP] Move to GradedArrays 0.16 and TensorAlgebra 0.19.3, simplify named broadcasting#243mtfishman wants to merge 9 commits into
mtfishman wants to merge 9 commits into
Conversation
Bumps the compat bounds to the GradedArrays 0.16 and TensorAlgebra 0.19 breaking releases, which needs no source changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Draft-only [sources] pin to the unregistered GradedArrays 0.16 branch. Remove once it registers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Named-tensor broadcasting now unwraps names and forwards to unnamed broadcasting, with linear-combination allocation handled by TensorAlgebra's broadcast `similar` instead of a prototype threaded through ITensorBase.
mtfishman
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 77.86% 75.18% -2.69%
==========================================
Files 30 29 -1
Lines 1812 1797 -15
==========================================
- Hits 1411 1351 -60
- Misses 401 446 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A 1-arg linear broadcast (`2 .* a`, `a ./ norm(a)`) now preserves the operand's codomain/domain split, and named broadcasting is now linear-only. A non-linear `f.(a)` errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replaces the per-node unname recursion with a generic `operation`/`arguments` tree-walk over `LinearBroadcasted`, so a new node type needs no new unname method. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Restore the non-linear fallback (`unnamed_broadcasted`) so a general element-wise `f.(a)` still routes through Base's generic broadcast, and drop the version to a non-breaking patch bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves ITensorBase onto GradedArrays 0.16 and TensorAlgebra 0.19.3, and reworks named-tensor broadcasting so a 1-arg linear broadcast (
2 .* a,conj.(a)) keeps its codomain/domain split.TODO
[sources]pin once GradedArrays 0.16 registers