Skip to content

Six-port parity on undirected graphs and non-finite floats; release 1.4.1 - #2

Merged
maheshvaikri-code merged 2 commits into
mainfrom
fix/port-parity-1.4.1
Nov 5, 2026
Merged

maheshvaikri-code merged 2 commits into
mainfrom
fix/port-parity-1.4.1

Conversation

@maheshvaikri-code

Copy link
Copy Markdown
Contributor

Summary

Two commits. The first finishes what #1 started; the second cuts the release.

1. Rust, C# and C++ parity (768038f)

#1 fixed Python, JS and TS. These three ports had the same two gaps where their string ids allow a fix, plus a worse one: any file carrying a meta.graph block was refused as an "unknown block kind" — so every undirected graph the other ports now write, and every Python MultiGraph file, was unloadable there.

Change Rust C# C++
Undirected graph writes meta.graph / directed false and reads it back, skipping the mirror row it already reconstructed ✓ ✓ ✓
Python MultiGraph document refused with a message naming it (no multigraph in these ports; loading would silently drop parallel edges) ParseError GraphError GraphError
NaN / ±Infinity refused on add_node, add_edge, update_node new InvalidPropertyValue ArgumentException std::invalid_argument
update_node validates property names (as the other ports already do) ✓ ✓ ✓

The Python-written undirected fixture (string ids, so representable everywhere) is byte-identical in all six ports and loads back undirected in each — pinned as a test in Rust, C# and C++. Directed output is unchanged, so the cross-port golden still holds.

2. Release 1.4.1 (8a283d0)

All version locations per CONTRIBUTING.md plus lockfiles and the two README crate snippets; changelog dated 2026-11-05. A patch rather than a minor: nothing that round-tripped correctly on 1.4.0 changes, and every input now refused was silently corrupted on reload before.

Verification

  • Rust: 69 → 76 passed (cargo test)
  • C#: 377 → 384 passed (dotnet test)
  • C++: 57 → 64 passed (test_ison_graph), 50 and 39 unchanged — built locally with MSVC 2022 against ison-cpp
  • Python: 498 passed, incl. the version-agreement test; TS/JS untouched since Keep a graph's meaning intact across dump and load (Python, JS, TS) #1
  • .github/scripts/check_cross_port_goldens.py: all six ports agree

Not in this PR

Node ids remain strings in Rust, C# and C++, so 1 and "1" are one node there and two elsewhere, and the negative-id / id-type changes from #1 have no equivalent. That is a public-API break across three ports and is left for 1.5.0.

After merge

Tag the merge commit v1.4.1, publish the GitHub release (fires publish-pypi), then dispatch publish-crates.yml, publish-npm.yml -f package=both and publish-nuget.yml against the tag.

🤖 Generated with Claude Code

maheshvaikri-code and others added 2 commits November 5, 2026 15:07
…oats

The identity patch (#1) fixed Python, JS and TS. These three ports had the
same two gaps where their string ids allow a fix, plus a worse one: any
file carrying a meta.graph block - every undirected graph the other ports
now write, and every Python MultiGraph file - was refused outright as an
"unknown block kind".

- An undirected graph writes meta.graph / directed false and reads it
  back, skipping the mirror row it has already reconstructed. The
  Python-written undirected fixture is now byte-identical in all six
  ports and loads back undirected in each. Directed output is unchanged.

- A Python MultiGraph document is refused with a message naming it, since
  these ports have no multigraph and would silently drop parallel edges.

- NaN and infinity are refused as property values on add_node, add_edge
  and update_node, and update_node validates property names as the other
  ports do.

Rust 69 -> 76 tests, C# 377 -> 384, C++ 57 -> 64; the cross-port golden
still agrees. Node ids remain strings in these ports - the one parity gap
left, and a breaking one for a later release.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
All six ports move to 1.4.1 together, per the release convention in
CONTRIBUTING.md: pyproject.toml and both __version__ strings, both
package.json files and their lockfiles, Cargo.toml and Cargo.lock,
IsonGraph.csproj, CMakeLists.txt, and the two README install snippets
that quote the crate version.

A patch rather than a minor because nothing that round-tripped correctly
on 1.4.0 changes: a directed graph's bytes are identical, and the inputs
now refused were all silently corrupted on reload before.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@maheshvaikri-code
maheshvaikri-code merged commit 027fb77 into main Nov 5, 2026
14 checks passed
@maheshvaikri-code
maheshvaikri-code deleted the fix/port-parity-1.4.1 branch November 5, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant