Ticket 8764 alarms dialog#1815
Open
Chsudeepta wants to merge 8 commits into
Open
Conversation
davidkeymer
requested changes
Jul 17, 2026
Comment on lines
+332
to
+335
| public void setLowLimitSeverity(String lowLimitSeverity) { | ||
| firePropertyChange("lowLimitSeverity", this.lowLimitSeverity, this.lowLimitSeverity = lowLimitSeverity); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Does this make sense to have a setter when the values aren't editable from the view? Is this supposed to be the case? Is it just for the initial update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
This change is required for enabling alarm configurations at block level.
Ticket
Ticket
Acceptance criteria
Documentation
https://isiscomputinggroup.github.io/ibex_developers_manual/system_components/BlockServer.html
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps