Correction in doc: dataverse.files.default-dataset-file-count-limit - #12687
Open
janvanmansum wants to merge 2 commits into
Open
janvanmansum wants to merge 2 commits into
janvanmansum wants to merge 2 commits into
Conversation
Member
Yes, makes sense. @stevenwinship can you please take a look? You added this setting in the following PR: |
pdurbin
changed the title
Member
|
Discussed at Triage Tuesday. Another option is to change the code. |
Contributor
|
@pdurbin The code is correct. A value of '0' is considered set so that no file may be uploaded. <0 is no limit. |
stevenwinship
approved these changes
Sep 15, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
pdurbin
reviewed
Sep 15, 2026
Member
There was a problem hiding this comment.
@janvanmansum can you please review this release note snippet and let me know if it looks ok?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Corrects an error in the docs
Which issue(s) this PR closes:
None
Special notes for your reviewer:
None
Suggestions on how to test this:
None
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
None
Is there a release notes update needed for this change?:
None
Additional documentation:
See: https://github.com/IQSS/dataverse/blob/develop/src/main/java/edu/harvard/iq/dataverse/DvObjectContainer.java#L281
dataverse.files.default-dataset-file-count-limitof 0 is considered set, since0 >= 0