Collection Page: Prevent infinite scrolling into blank space - #1050
Open
youseihuayu-wonderful wants to merge 1 commit into
Open
Collection Page: Prevent infinite scrolling into blank space#1050youseihuayu-wonderful wants to merge 1 commit into
youseihuayu-wonderful wants to merge 1 commit into
Conversation
ChengShi-1
requested changes
Aug 19, 2026
ChengShi-1
left a comment
Contributor
There was a problem hiding this comment.
Looks good with the fix! I left a comment about tests below, and could you also add a changelog entry?
| cy.findByTestId('collection-items-list-infinite-scroll-skeleton').should('exist') | ||
| }) | ||
|
|
||
| it('keeps repeated infinite scrolling within the items list page boundary', () => { |
Contributor
There was a problem hiding this comment.
These two tests are failing on my local end due to some environment-dependent rounding differences. I suggest changing the strict equality assertions to allow a 1px tolerance with closeTo(..., 1), avoiding flaky browser-specific layout measurements.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prevents the Collection Page from scrolling into blank space after repeatedly loading results through infinite scrolling.
In the affected layout, the page-level scroll range can grow as more results are added to the internal results list, even though the rendered page content and footer remain in the same bounds.
This PR:
The change is intentionally limited to the collection items scroll container. It does not redesign the scrolling architecture or introduce broader CSS containment changes.
Which issue(s) this PR closes:
Suggestions on how to test this:
Does this PR introduce a user interface change?
No intended visual change. It corrects the page scroll boundary.
Is there a release notes or changelog update needed for this change?
No.
Testing performed: