Cached property patch - #52
Open
vreshniak wants to merge 2 commits into
Open
Conversation
`def _extract_y_train_from_dataset` implements cached_property logic
vreshniak
requested review from
Lance-Drane and
konstpieper
and removed request for
konstpieper
August 6, 2026 13:30
Lance-Drane
reviewed
Aug 6, 2026
| def Y_best(self) -> float: | ||
| return self.Y_train.max() if self.y_is_good else self.Y_train.min() | ||
|
|
||
| def clear_cached_properties(self) -> None: |
Contributor
There was a problem hiding this comment.
I'll have to look at this but I think this function impacts more than it should
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stacked PR. Should be merged after indexed_strategies PR is merged to develop
Changes:
def _extract_y_train_from_datasetwith@cached_propertylogic similar to other cached properties inclass ServersideInputBase.def clear_cached_propertiesmethod used in batched strategies